Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1204753002: Fix cluster-fuzz found regression in d8 when deserializing ArrayBuffer (Closed)

Created:
5 years, 6 months ago by binji
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix cluster-fuzz found regression in d8 when deserializing ArrayBuffer BUG=503578 R=jarin@chromium.org LOG=n Committed: https://crrev.com/10b6af71b8eea3abb231fb5ef0333be965f2f3eb Cr-Commit-Position: refs/heads/master@{#29244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/d8.cc View 1 chunk +0 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-503578.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
PTAL, the DCHECK was erroneous. I assumed that Object keys always are strings, but in ...
5 years, 6 months ago (2015-06-23 18:46:24 UTC) #1
Jarin
lgtm
5 years, 6 months ago (2015-06-24 04:03:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204753002/1
5 years, 6 months ago (2015-06-24 04:22:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 04:23:49 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 04:24:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10b6af71b8eea3abb231fb5ef0333be965f2f3eb
Cr-Commit-Position: refs/heads/master@{#29244}

Powered by Google App Engine
This is Rietveld 408576698