Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

Issue 1204733002: dart2js cps: Make Identical a built-in and add Interceptor to Tree IR. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
index 00f71827f28c571ad84b3c8b53558307fcab3516..029fda63a6d2623428c07b0fb2e82c2cb7b9df2c 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
@@ -704,19 +704,6 @@ class CreateInstance extends Primitive {
accept(Visitor visitor) => visitor.visitCreateInstance(this);
}
-/// Compare objects for identity.
-///
-/// It is an error pass in a value that does not correspond to a Dart value,
-/// such as an interceptor or a box.
-class Identical extends Primitive {
- final Reference<Primitive> left;
- final Reference<Primitive> right;
- Identical(Primitive left, Primitive right)
- : left = new Reference<Primitive>(left),
- right = new Reference<Primitive>(right);
- accept(Visitor visitor) => visitor.visitIdentical(this);
-}
-
class Interceptor extends Primitive {
final Reference<Primitive> input;
final Set<ClassElement> interceptedClasses;
@@ -974,7 +961,6 @@ abstract class Visitor<T> {
T visitMutableVariable(MutableVariable node);
T visitNonTailThrow(NonTailThrow node);
T visitGetStatic(GetStatic node);
- T visitIdentical(Identical node);
T visitInterceptor(Interceptor node);
T visitCreateInstance(CreateInstance node);
T visitGetField(GetField node);
@@ -1182,13 +1168,6 @@ class RecursiveVisitor implements Visitor {
processReference(node.value);
}
- processIdentical(Identical node) {}
- visitIdentical(Identical node) {
- processIdentical(node);
- processReference(node.left);
- processReference(node.right);
- }
-
processInterceptor(Interceptor node) {}
visitInterceptor(Interceptor node) {
processInterceptor(node);

Powered by Google App Engine
This is Rietveld 408576698