Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: pkg/compiler/lib/src/cps_ir/builtin_operator.dart

Issue 1204733002: dart2js cps: Make Identical a built-in and add Interceptor to Tree IR. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/builtin_operator.dart
diff --git a/pkg/compiler/lib/src/cps_ir/builtin_operator.dart b/pkg/compiler/lib/src/cps_ir/builtin_operator.dart
index 70fe1b6d949e84113af8de7d39a2e0ab8490a5dc..9010bc28caf22df774e00990f126f460a59fb720 100644
--- a/pkg/compiler/lib/src/cps_ir/builtin_operator.dart
+++ b/pkg/compiler/lib/src/cps_ir/builtin_operator.dart
@@ -47,7 +47,12 @@ enum BuiltinOperator {
/// Returns true if the two arguments are the same value, and that value is
/// not NaN, or if one argument is +0 and the other is -0.
///
- /// At most one of the arguments may be null.
+ /// Compiled as a static method call.
+ Identical,
+
+ /// Like [Identical], except at most one argument may be null.
+ ///
+ /// Compiles to `===`.
StrictEq,
/// Negated version of [StrictEq]. Introduced by [LogicalRewriter] in Tree IR.
@@ -60,6 +65,8 @@ enum BuiltinOperator {
/// One of the following must hold:
/// - At least one argument is null.
/// - Arguments are both strings, or both booleans, or both numbers.
+ ///
+ /// Compiles to `==`.
LooseEq,
/// Negated version of [LooseEq]. Introduced by [LogicalRewriter] in Tree IR.
@@ -67,6 +74,8 @@ enum BuiltinOperator {
/// Returns true if the argument is false, +0. -0, NaN, the empty string,
/// or null.
+ ///
+ /// Compiles to `!`.
IsFalsy,
/// Returns true if the argument is a number.
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('j') | pkg/compiler/lib/src/cps_ir/type_propagation.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698