Make webview_licenses.py script to use licensecheck.pl

android_webview/tools/webview_licenses.py

 #!/usr/bin/python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Checks third-party licenses for the purposes of the Android WebView build.
 
 The Android tree includes a snapshot of Chromium in order to power the system
 WebView.  This tool checks that all code uses open-source licenses compatible
 with Android, and that we meet the requirements of those licenses. It can also
@@ skipping 68 matching lines @@
   """Checks that all files which are not in a listed third-party directory,
   and which do not use the standard Chromium license, are whitelisted.
   Args:
     directory_list: The list of directories.
     whitelisted_files: The whitelist of files.
   Returns:
     True if all files with non-standard license headers are whitelisted and the
     whitelist contains no stale entries, otherwise false.
   """
 
-  # Matches one of ...
-  # - '[Cc]opyright', but not when followed by
-  #   ' 20[0-9][0-9] The Chromium Authors.', with optional (c) and date range
-  # - '([Cc]) (19|20)[0-9][0-9]', but not when preceeded by the word copyright,
-  #   as this is handled above
-  regex = '[Cc]opyright(?!( \(c\))? 20[0-9][0-9](-20[0-9][0-9])? ' \
-          'The Chromium Authors\. All rights reserved\.)' \
-          '|' \
-          '(?<!(pyright |opyright))\([Cc]\) (19|20)[0-9][0-9]'
+  directory_list = [d for d in directory_list if not 'third_party' in d]
+  # This makes the ignore regexp shorter
+  directory_list.append('third_party')
+  # 'Copyright' appears in license agreements
+  directory_list.append('chrome/app/resources')
+  # Arm sysroot tools, doesn't exist in the snapshot
+  directory_list.append('arm-sysroot')
 
-  args = ['grep',
-          '-rPlI',
-          '--exclude', '*.orig',
-          '--exclude', '*.rej',
-          '--exclude-dir', 'third_party',
-          '--exclude-dir', 'out',
-          '--exclude-dir', '.git',
-          '--exclude-dir', '.svn',
-          regex,
+  ignore_patterns = []
+  for d in directory_list:
+    ignore_patterns.append('(?:/' + d.replace('+', '\+') + '/)')
+
+  args = ['third_party/devscripts/licensecheck.pl',
+          '--lines', '99',
+          '--copyright',
+          '--machine',
+          '--recursive',
+          '--check', '\.(c(c|pp|xx)?|h(h|pp|xx)?|p(l|m)|xs|sh|php|py(|x)|rb' \

[Paweł Hajdan Jr., 2013/01/25 17:54:33]

Do you need to use --check? Why?

[mnaganov (inactive), 2013/01/28 14:51:54]

Because the pattern in licensecheck.pl apparently misses
"js|html|pac|mm|asm|idl"

[Paweł Hajdan Jr., 2013/01/28 16:28:29]

Why not update the pattern in licensecheck.pl then? :)

[mnaganov (inactive), 2013/01/28 17:12:38]

I was considering these additions to be Chromium-specific. Moved to
licensecheck.pl.

+            '|java|vala|el|sc(i|e)|cs|pas|inc|dtd|xsl|mod|m|tex|mli?|js|html' \
+            '|pac|mm|asm|idl)$',
+          '--ignore', '|'.join(ignore_patterns),
           '.']
   p = subprocess.Popen(args=args, cwd=REPOSITORY_ROOT, stdout=subprocess.PIPE)
-  files = p.communicate()[0].splitlines()
+  lines = p.communicate()[0].splitlines()
 
-  directory_list = directory_list[:]
-  # Ignore these tools.
-  directory_list.append('android_webview/tools/')
-  # This is a build intermediate directory.
-  directory_list.append('chrome/app/theme/google_chrome/')
-  # This is tests directory, doesn't exist in the snapshot
-  directory_list.append('content/test/data/')
-  # This is a test output directory.
-  directory_list.append('data/dom_perf/')
-  # This is a test output directory.
-  directory_list.append('data/page_cycler/')
-  # 'Copyright' appears in strings.
-  directory_list.append('chrome/app/resources/')
-  # This is a Chrome on Linux reference build, doesn't exist in the snapshot
-  directory_list.append('chrome/tools/test/reference_build/chrome_linux/')
-  # Remoting internal tools, doesn't exist in the snapshot
-  directory_list.append('remoting/appengine/')
-  # Histogram tools, doesn't exist in the snapshot
-  directory_list.append('tools/histograms/')
-  # Arm sysroot tools, doesn't exist in the snapshot
-  directory_list.append('arm-sysroot/')
-  # Windows-only
-  directory_list.append('tools/win/toolchain/7z/')
-
-  # Exclude files under listed directories and some known offenders.
   offending_files = []
-  for x in files:
-    x = os.path.normpath(x)
-    is_in_listed_directory = False
-    for y in directory_list:
-      if x.startswith(y):
-        is_in_listed_directory = True
+  allowed_copyrights = '^(?:\*No copyright\*' \
+      '|20[0-9][0-9](?:-20[0-9][0-9])? The Chromium Authors\. ' \
+      'All rights reserved.*)$'
+  allowed_copyrights_re = re.compile(allowed_copyrights)
+  for l in lines:
+    entries = l.split('\t')
+    if entries[1] == "GENERATED FILE":
+      continue
+    copyrights = entries[2].split(' / ')
+    for c in copyrights:
+      if c and not allowed_copyrights_re.match(c):
+        offending_files.append(os.path.normpath(entries[0]))
         break
-    if not is_in_listed_directory:
-      offending_files.append(x)
 
   all_files_valid = True
   unknown = set(offending_files) - set(whitelisted_files)
   if unknown:
     print 'The following files contain a third-party license but are not in ' \
           'a listed third-party directory and are not whitelisted. You must ' \
           'add the following files to the whitelist.\n%s' % \
           '\n'.join(sorted(unknown))
     all_files_valid = False
 
@@ skipping 124 matching lines @@
       return 1
   elif args[0] == 'notice':
     print GenerateNoticeFile()
     return 0
 
   parser.print_help()
   return 1
 
 if __name__ == '__main__':
   sys.exit(main())