Change the SearchBox API from using the start/end margins of the location bar to using the start ma…

chrome/renderer/resources/extensions/searchbox_api.js

Index: chrome/renderer/resources/extensions/searchbox_api.js
diff --git a/chrome/renderer/resources/extensions/searchbox_api.js b/chrome/renderer/resources/extensions/searchbox_api.js
index 06aa877008b1e39007fcbf84b9d2c65d64b9fa5e..52ca1feef9169a031065b1bfb3a2d25b1c53be8c 100644
--- a/chrome/renderer/resources/extensions/searchbox_api.js
+++ b/chrome/renderer/resources/extensions/searchbox_api.js
@@ -37,8 +37,8 @@ if (!chrome.searchBox) {
     native function GetY();
     native function GetWidth();
     native function GetHeight();
-    native function GetStartMargin();
-    native function GetEndMargin();
+    native function GetLocationBarMargin();
+    native function GetLocationBarWidth();
     native function GetRightToLeft();
     native function GetAutocompleteResults();
     native function GetContext();
@@ -208,8 +208,8 @@ if (!chrome.searchBox) {
     this.__defineGetter__('y', GetY);
     this.__defineGetter__('width', GetWidth);
     this.__defineGetter__('height', GetHeight);
-    this.__defineGetter__('startMargin', GetStartMargin);
-    this.__defineGetter__('endMargin', GetEndMargin);
+    this.__defineGetter__('locationBarMargin', GetLocationBarMargin);

[samarth, 2013/02/05 23:39:33]

I like that the names are more explicit throughout the chrome code, but the
names in the API should still be startMargin and width. From the point of view
of a page implementing the api, it should just be
  chrome.searchBox.startMargin
not
  chrome.searchBox.locationBarMargin

[melevin, 2013/02/06 23:44:05]

Done.

+    this.__defineGetter__('locationBarWidth', GetLocationBarWidth);
     this.__defineGetter__('rtl', GetRightToLeft);
     this.__defineGetter__('nativeSuggestions', GetAutocompleteResultsWrapper);
     this.__defineGetter__('isKeyCaptureEnabled', IsKeyCaptureEnabled);