Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 12047107: Change the SearchBox API from using the start/end margins of the location bar to using the start ma… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simplified LocationBarView::OnBoundsChanged Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index 082ac95b02e5a6643bd076e0be50b98735ec0752..0be3882c8181847b0a0d9dcceb1853a6dd04413d 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -250,7 +250,8 @@ class SearchBoxExtensionWrapper : public v8::Extension {
// region of the search box that overlaps the window.
static v8::Handle<v8::Value> GetY(const v8::Arguments& args);
- // Gets the width of the region of the search box that overlaps the window.
+ // Gets the width of the region of the search box that overlaps the window,
+ // i.e., the width of the omnibox.
static v8::Handle<v8::Value> GetWidth(const v8::Arguments& args);
// Gets the height of the region of the search box that overlaps the window.
@@ -259,14 +260,9 @@ class SearchBoxExtensionWrapper : public v8::Extension {
// Gets Most Visited Items.
static v8::Handle<v8::Value> GetMostVisitedItems(const v8::Arguments& args);
- // Gets the width of the margin from the start-edge of the page to the start
- // of the suggestions dropdown.
+ // Gets the start-edge margin to use with extended Instant.
static v8::Handle<v8::Value> GetStartMargin(const v8::Arguments& args);
- // Gets the width of the margin from the end-edge of the page to the end of
- // the suggestions dropdown.
- static v8::Handle<v8::Value> GetEndMargin(const v8::Arguments& args);
-
// Returns true if the Searchbox itself is oriented right-to-left.
static v8::Handle<v8::Value> GetRightToLeft(const v8::Arguments& args);
@@ -365,8 +361,6 @@ v8::Handle<v8::FunctionTemplate> SearchBoxExtensionWrapper::GetNativeFunction(
return v8::FunctionTemplate::New(GetMostVisitedItems);
if (name->Equals(v8::String::New("GetStartMargin")))
return v8::FunctionTemplate::New(GetStartMargin);
- if (name->Equals(v8::String::New("GetEndMargin")))
- return v8::FunctionTemplate::New(GetEndMargin);
if (name->Equals(v8::String::New("GetRightToLeft")))
return v8::FunctionTemplate::New(GetRightToLeft);
if (name->Equals(v8::String::New("GetAutocompleteResults")))
@@ -480,7 +474,6 @@ v8::Handle<v8::Value> SearchBoxExtensionWrapper::GetWidth(
const v8::Arguments& args) {
content::RenderView* render_view = GetRenderView();
if (!render_view) return v8::Undefined();
-
return v8::Int32::New(SearchBox::Get(render_view)->GetPopupBounds().width());
}
@@ -502,14 +495,6 @@ v8::Handle<v8::Value> SearchBoxExtensionWrapper::GetStartMargin(
}
// static
-v8::Handle<v8::Value> SearchBoxExtensionWrapper::GetEndMargin(
- const v8::Arguments& args) {
- content::RenderView* render_view = GetRenderView();
- if (!render_view) return v8::Undefined();
- return v8::Int32::New(SearchBox::Get(render_view)->GetEndMargin());
-}
-
-// static
v8::Handle<v8::Value> SearchBoxExtensionWrapper::GetRightToLeft(
const v8::Arguments& args) {
return v8::Boolean::New(base::i18n::IsRTL());

Powered by Google App Engine
This is Rietveld 408576698