Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6231)

Unified Diff: chrome/renderer/searchbox/searchbox.h

Issue 12047107: Change the SearchBox API from using the start/end margins of the location bar to using the start ma… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox.h
diff --git a/chrome/renderer/searchbox/searchbox.h b/chrome/renderer/searchbox/searchbox.h
index b6ab5aafafa7e81cdd409d5fc6787e75ac03a22c..b56c446b815ea0c8b83d6bc2413bf7ce007a985b 100644
--- a/chrome/renderer/searchbox/searchbox.h
+++ b/chrome/renderer/searchbox/searchbox.h
@@ -53,10 +53,9 @@ class SearchBox : public content::RenderViewObserver,
const string16& omnibox_font() const { return omnibox_font_; }
size_t omnibox_font_size() const { return omnibox_font_size_; }
- // These functions return the start/end margins of the page text area,
- // adjusted for the page zoom.
+ // In extended Instant, returns the start-edge margin of the location bar in
+ // screen pixels.
int GetStartMargin() const;
- int GetEndMargin() const;
// Returns the bounds of the omnibox popup in screen coordinates.
gfx::Rect GetPopupBounds() const;
@@ -79,7 +78,7 @@ class SearchBox : public content::RenderViewObserver,
void OnSubmit(const string16& query);
void OnCancel(const string16& query);
void OnPopupResize(const gfx::Rect& bounds);
- void OnMarginChange(int start, int end);
+ void OnMarginChange(int margin, int width);
void OnDetermineIfPageSupportsInstant();
void OnAutocompleteResults(
const std::vector<InstantAutocompleteResult>& results);
@@ -104,7 +103,6 @@ class SearchBox : public content::RenderViewObserver,
size_t selection_end_;
size_t results_base_;
int start_margin_;
- int end_margin_;
gfx::Rect popup_bounds_;
std::vector<InstantAutocompleteResult> autocomplete_results_;
size_t last_results_base_;

Powered by Google App Engine
This is Rietveld 408576698