chrome/browser/ui/browser_instant_controller.h - Issue 12047107: Change the SearchBox API from using the start/end margins of the location bar to using the start ma…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_instant_controller.h

Issue 12047107: Change the SearchBox API from using the start/end margins of the location bar to using the start ma… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added test Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/instant/instant_extended_browsertest.cc ('K') | « chrome/browser/instant/instant_tab.cc ('k') | chrome/browser/ui/browser_instant_controller.cc » ('j') | chrome/renderer/searchbox/searchbox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_instant_controller.h

diff --git a/chrome/browser/ui/browser_instant_controller.h b/chrome/browser/ui/browser_instant_controller.h

index f154992bd2343718214995631babb4e24e882da3..f47486c65ff8ab3d18b3f0afc9ec2bb466c19d40 100644

--- a/chrome/browser/ui/browser_instant_controller.h

+++ b/chrome/browser/ui/browser_instant_controller.h

@@ -90,8 +90,8 @@ class BrowserInstantController : public content::NotificationObserver,

// Invoked by the InstantController when it wants to open a URL.

void OpenURLInCurrentTab(const GURL& url, content::PageTransition transition);

- // Sets the start and end margins of the omnibox text area.

- void SetMarginSize(int start, int end);

+ // Sets the stored start-edge margin and width of the location bar.

+ void SetStartMarginAndWidth(int margin, int width);

private:

// Sets the value of |instant_| based on value from profile. Invoked