Change the SearchBox API from using the start/end margins of the location bar to using the start ma…

chrome/renderer/resources/extensions/searchbox_api.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var chrome;
 if (!chrome)
   chrome = {};
 if (!chrome.searchBox) {
   chrome.searchBox = new function() {
     var safeObjects = {};
@@ skipping 19 matching lines @@
     //                            Private functions
     // =========================================================================
     native function GetQuery();
     native function GetVerbatim();
     native function GetSelectionStart();
     native function GetSelectionEnd();
     native function GetX();
     native function GetY();
     native function GetWidth();
     native function GetHeight();
-    native function GetStartMargin();
-    native function GetEndMargin();
+    native function GetLocationBarMargin();
+    native function GetLocationBarWidth();
     native function GetRightToLeft();
     native function GetAutocompleteResults();
     native function GetContext();
     native function GetDisplayInstantResults();
     native function GetFont();
     native function GetFontSize();
     native function GetThemeBackgroundInfo();
     native function GetThemeAreaHeight();
     native function IsKeyCaptureEnabled();
     native function NavigateContentWindow();
@@ skipping 149 matching lines @@
     //                           Exported functions
     // =========================================================================
     this.__defineGetter__('value', GetQuery);
     this.__defineGetter__('verbatim', GetVerbatim);
     this.__defineGetter__('selectionStart', GetSelectionStart);
     this.__defineGetter__('selectionEnd', GetSelectionEnd);
     this.__defineGetter__('x', GetX);
     this.__defineGetter__('y', GetY);
     this.__defineGetter__('width', GetWidth);
     this.__defineGetter__('height', GetHeight);
-    this.__defineGetter__('startMargin', GetStartMargin);
-    this.__defineGetter__('endMargin', GetEndMargin);
+    this.__defineGetter__('locationBarMargin', GetLocationBarMargin);

[samarth, 2013/02/05 23:39:33]

I like that the names are more explicit throughout the chrome code, but the
names in the API should still be startMargin and width. From the point of view
of a page implementing the api, it should just be
  chrome.searchBox.startMargin
not
  chrome.searchBox.locationBarMargin

[melevin, 2013/02/06 23:44:05]

Done.

+    this.__defineGetter__('locationBarWidth', GetLocationBarWidth);
     this.__defineGetter__('rtl', GetRightToLeft);
     this.__defineGetter__('nativeSuggestions', GetAutocompleteResultsWrapper);
     this.__defineGetter__('isKeyCaptureEnabled', IsKeyCaptureEnabled);
     this.__defineGetter__('context', GetContext);
     this.__defineGetter__('displayInstantResults', GetDisplayInstantResults);
     this.__defineGetter__('themeBackgroundInfo', GetThemeBackgroundInfo);
     this.__defineGetter__('themeAreaHeight', GetThemeAreaHeight);
     this.__defineGetter__('font', GetFont);
     this.__defineGetter__('fontSize', GetFontSize);
     this.setSuggestions = function(text) {
@@ skipping 30 matching lines @@
     this.onsubmit = null;
     this.oncancel = null;
     this.onresize = null;
     this.onautocompleteresults = null;
     this.onkeypress = null;
     this.onkeycapturechange = null;
     this.oncontextchange = null;
     this.onmarginchange = null;
   };
 }