Issue 12047075: Fix race condition that occurs if ResourceContext::SetUserData is called on the IO thread before In…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12047075: Fix race condition that occurs if ResourceContext::SetUserData is called on the IO thread before In… (Closed)

Created:
7 years, 11 months ago by jam

Modified:
7 years, 11 months ago

Reviewers:
awong

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix race condition that occurs if ResourceContext::SetUserData is called on the IO thread before InitializeResourceContext is called on the UI thread. We don't see this now because we don't set user data on the IO thread at initialization. In https://codereview.chromium.org/12049052/ I encountered this when I tried to set user data on the IO thread. The fix is to ensure that InitializeResourceContext is called before ResourceContext is used on the IO thread. BUG=169170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178598

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	content/browser/storage_partition_impl_map.cc	View		2 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

awong

LGTM w/ nit Can you add to the comment above that moving this into Get() ...

7 years, 11 months ago (2013-01-24 17:12:09 UTC) #2

jam

7 years, 11 months ago (2013-01-24 17:16:14 UTC) #3

On 2013/01/24 17:12:09, awong wrote:
> LGTM w/ nit
> 
> Can you add to the comment above that moving this into Get() before
> partitions_[] is set causes reentrency?

sure

Expand Messages | Collapse Messages