Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(49)

Issue 12047073: Merge 140324 (Closed)

Created:
7 years, 8 months ago by tkent
Modified:
7 years, 8 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 140324 > INPUT_MULTIPLE_FIELDS_UI: should not dispatch 'input' events if the element value is not updated > https://bugs.webkit.org/show_bug.cgi?id=107429 > > Reviewed by Kentaro Hara. > > Source/WebCore: > > http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#common-event-behaviors > > any time the user causes the element's value to change, the user agent > > must queue a task to fire a simple event that bubbles named input at the > > input element. > > Tests: > fast/forms/time-multiple-fields/time-multiple-fields-keyboard-event.html > is updated to cover this change. > > * html/BaseMultipleFieldsDateAndTimeInputType.cpp: > (WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged): > If the new value is equivalent to the old value, don't dispatch events. > However we should recalculate validity and call notifyFormStateChanged > because input.validity.badInput state might be changed. > > LayoutTests: > > * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: > * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: > TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -15 lines) Patch
M LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html View 2 chunks +30 lines, -11 lines 0 comments Download
M LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
7 years, 8 months ago (2013-01-24 05:42:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698