Add apk for running content_browsertests

Add apk for running content_browsertests
    
Split off org.chromium.content_shell into:
      org.chromium.content_shell - content shell java code, builds a jar, directory structure similar to other jar targets
      org.chromium.content_shell_apk - application code to build content_shell_apk, directory structure similar to that of android application
      org.chromium.content_browsertests_apk - application code to build content_browsertests_apk

Also splitting content/shell/android/res into:
  - content/shell/android/java/res 
  - content/shell/android/shell_apk/res

Both content_shell_apk and content_browsertests_apk will depend on content_shell_java target to include java/res needed to show a shell based browser.
    
I will do another CL to move The java files for content_shell_tests_apk to content_shell_apk package.
    
BUG=138275
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179189

[nilesh, 2013-01-24 21:58:23]

Hi, This is just adding the target to build the APK and provides a way to
override the MessagePump used for each test suite.

Most of the CL is splitting the existing content_shell package.

cjhopman: Please look at build changes and build rules for  jars and apks
(build/ and gypi changes)
jcivelli: Please look at how we plan to run content_browsertests bundles in and
APK (content/shell/android/browsertests_apk/ and content/test/)
yfriedman: Overall splitting of packages

I will add base/ and content/ OWNERS after initial review.

[nilesh, 2013-01-24 22:39:14]

Actually adding reviewers this time.

Hi, This is just adding the target to build the APK and provides a way to
override the MessagePump used for each test suite.

Most of the CL is splitting the existing content_shell package.

cjhopman: Please look at build changes and build rules for  jars and apks
(build/ and gypi changes)
jcivelli: Please look at how we plan to run content_browsertests bundles in and
APK (content/shell/android/browsertests_apk/ and content/test/)
yfriedman: Overall splitting of packages

I will add base/ and content/ OWNERS after initial review.

[nilesh, 2013-01-25 17:48:11]

mark: base/
jam: content/test and content/public/test

[Mark Mentovai, 2013-01-25 17:54:44]

LGTM for base OWNERS review.

[cjhopman, 2013-01-25 18:04:30]

https://codereview.chromium.org/12047068/diff/7005/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/12047068/diff/7005/build/java_apk.gypi#newcode43
build/java_apk.gypi:43: #    (default: <PRODUCT_DIR>/<package_name>/assets).
Change <PRODUCT_DIR>/<package_name>/assets to
<(ant_build_out)/<(package_name)/assets.

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi...
content/content_shell.gypi:58: 'shell/android/shell_jni_registrar.cc',
nit: alphabetize

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi...
content/content_shell.gypi:565:
'shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java',
nit: alphabetize

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi...
content/content_shell.gypi:621: # only be used by tagets which instrument
content_shell_apk.
s/tagets/targets

https://codereview.chromium.org/12047068/diff/7005/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/12047068/diff/7005/content/content_tests.gypi...
content/content_tests.gypi:967: 'content_browsertests',
nit: alphabetize

[Jay Civelli, 2013-01-25 18:46:14]

lgtm

https://codereview.chromium.org/12047068/diff/7005/content/shell/android/brow...
File content/shell/android/browsertests_apk/content_browser_tests_android.cc
(right):

https://codereview.chromium.org/12047068/diff/7005/content/shell/android/brow...
content/shell/android/browsertests_apk/content_browser_tests_android.cc:123: if
(!RegisterNativesImpl(env)) {
Nit: remove curly braces.

[Yaron, 2013-01-25 19:36:20]

lgtm

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi...
content/content_shell.gypi:606: ],
nit: indentation

[nilesh, 2013-01-26 01:25:59]

Addressed all comments.

https://codereview.chromium.org/12047068/diff/7005/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/12047068/diff/7005/build/java_apk.gypi#newcode43
build/java_apk.gypi:43: #    (default: <PRODUCT_DIR>/<package_name>/assets).
On 2013/01/25 18:04:30, cjhopman wrote:
> Change <PRODUCT_DIR>/<package_name>/assets to
> <(ant_build_out)/<(package_name)/assets.

Done.

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi...
content/content_shell.gypi:58: 'shell/android/shell_jni_registrar.cc',
On 2013/01/25 18:04:30, cjhopman wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi...
content/content_shell.gypi:565:
'shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java',
On 2013/01/25 18:04:30, cjhopman wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi...
content/content_shell.gypi:606: ],
On 2013/01/25 19:36:20, Yaron wrote:
> nit: indentation

Done.

https://codereview.chromium.org/12047068/diff/7005/content/content_shell.gypi...
content/content_shell.gypi:621: # only be used by tagets which instrument
content_shell_apk.
On 2013/01/25 18:04:30, cjhopman wrote:
> s/tagets/targets

Done.

https://codereview.chromium.org/12047068/diff/7005/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/12047068/diff/7005/content/content_tests.gypi...
content/content_tests.gypi:967: 'content_browsertests',
On 2013/01/25 18:04:30, cjhopman wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/12047068/diff/7005/content/shell/android/brow...
File content/shell/android/browsertests_apk/content_browser_tests_android.cc
(right):

https://codereview.chromium.org/12047068/diff/7005/content/shell/android/brow...
content/shell/android/browsertests_apk/content_browser_tests_android.cc:123: if
(!RegisterNativesImpl(env)) {
On 2013/01/25 18:46:14, Jay Civelli wrote:
> Nit: remove curly braces.

Done.

[cjhopman, 2013-01-26 01:28:07]

lgtm

[jam, 2013-01-28 17:33:45]

lgtm

[commit-bot: I haz the power, 2013-01-28 18:12:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12047068/15001

[commit-bot: I haz the power, 2013-01-28 21:21:02]

Change committed as 179189