Issue 12047064: libmtp: Rename patches/15_read_chunks.diff to patches/15_read_chunks.patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12047064: libmtp: Rename patches/15_read_chunks.diff to patches/15_read_chunks.patch. (Closed)

Created:
7 years, 11 months ago by Lei Zhang

Modified:
7 years, 11 months ago

Reviewers:
Jorge Lucangeli Obes

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/libmtp/

Visibility:
Public.

More Reviews

Description

libmtp: Rename patches/15_read_chunks.diff to patches/15_read_chunks.patch. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178446

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, -98 lines)			Patch
	D	patches/15_read_chunks.diff	View		1 chunk	+0 lines, -99 lines	0 comments	Download
	A +	patches/15_read_chunks.patch	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jorge Lucangeli Obes

On 2013/01/24 00:08:20, Lei Zhang wrote: > All the other patches are named .patch. Was ...

7 years, 11 months ago (2013-01-24 00:24:50 UTC) #2

Lei Zhang

On 2013/01/24 00:24:50, Jorge Lucangeli Obes wrote: > On 2013/01/24 00:08:20, Lei Zhang wrote: > ...

7 years, 11 months ago (2013-01-24 00:28:11 UTC) #3

Jorge Lucangeli Obes

7 years, 11 months ago (2013-01-24 00:29:22 UTC) #4

On 2013/01/24 00:28:11, Lei Zhang wrote:
> On 2013/01/24 00:24:50, Jorge Lucangeli Obes wrote:
> > On 2013/01/24 00:08:20, Lei Zhang wrote:
> > > All the other patches are named .patch.
> > 
> > Was the diff for this issue created correctly? The new file shows as empty.
> 
> The raw diff has:
> 
> ### BEGIN SVN COPY METADATA
> #$ cp trunk/deps/third_party/libmtp/patches/15_read_chunks.diff
> patches/15_read_chunks.patch
> ### END SVN COPY METADATA
> 
> I plan to commit this directly, which should work fine.

May the Gods of the SVN be with you.

lgtm

Expand Messages | Collapse Messages