Added parallel marking threads.

Added parallel marking threads.


BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13569

[Michael Starzinger, 2013-01-31 11:32:17]

Since you will need to rebase this on top of the parallel sweeper anyways, can
we do the rebase before the review? Because I imagine there will be a lot of
conflicts.

[Hannes Payer (out of office), 2013-01-31 12:07:42]

Done, merged.

On 2013/01/31 11:32:17, Michael Starzinger wrote:
> Since you will need to rebase this on top of the parallel sweeper anyways, can
> we do the rebase before the review? Because I imagine there will be a lot of
> conflicts.

[Michael Starzinger, 2013-01-31 14:00:04]

LGTM (just a few nits).

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/mark-compact.h
File src/mark-compact.h (right):

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/mark-compact.h...
src/mark-compact.h:693: void MarkInParallel();
This is getting clunky, can we group these functions into a "// Parallel
sweeping support." and a "// Parallel marking support." section?

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread.cc
File src/marking-thread.cc (right):

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread...
src/marking-thread.cc:1: // Copyright 2012 the V8 project authors. All rights
reserved.
2013

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread.h
File src/marking-thread.h (right):

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread...
src/marking-thread.h:1: // Copyright 2012 the V8 project authors. All rights
reserved.
2013

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread...
src/marking-thread.h:38: #include "heap.h"
Is it possible to alpha-sort the includes or does that cause dependency errors?

[Hannes Payer (out of office), 2013-01-31 14:09:10]

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/mark-compact.h
File src/mark-compact.h (right):

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/mark-compact.h...
src/mark-compact.h:693: void MarkInParallel();
On 2013/01/31 14:00:04, Michael Starzinger wrote:
> This is getting clunky, can we group these functions into a "// Parallel
> sweeping support." and a "// Parallel marking support." section?

Done.

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread.cc
File src/marking-thread.cc (right):

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread...
src/marking-thread.cc:1: // Copyright 2012 the V8 project authors. All rights
reserved.
On 2013/01/31 14:00:04, Michael Starzinger wrote:
> 2013

Done.

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread.h
File src/marking-thread.h (right):

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread...
src/marking-thread.h:1: // Copyright 2012 the V8 project authors. All rights
reserved.
On 2013/01/31 14:00:04, Michael Starzinger wrote:
> 2013

Done.

https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread...
src/marking-thread.h:38: #include "heap.h"
On 2013/01/31 14:00:04, Michael Starzinger wrote:
> Is it possible to alpha-sort the includes or does that cause dependency
errors?

It results in dependency errors.

[tfarina, 2013-01-31 21:20:30]

https://codereview.chromium.org/12047044/diff/14009/src/marking-thread.h
File src/marking-thread.h (right):

https://codereview.chromium.org/12047044/diff/14009/src/marking-thread.h#newc...
src/marking-thread.h:53: delete start_marking_semaphore_;
isn't there a scoped_ptr type to handle this?