Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 12047039: download: Remove DownloadManager::MockDownloadOpenForTesting (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and comment fix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_manager_impl.h ('k') | content/public/browser/download_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index 06cdb625685327d12ffa0d59656183ad7ecce736..a71a06542bac51605113e73bc86b5c1454c88105 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -222,8 +222,7 @@ DownloadManagerImpl::DownloadManagerImpl(
shutdown_needed_(false),
browser_context_(NULL),
delegate_(NULL),
- net_log_(net_log),
- open_enabled_(true) {
+ net_log_(net_log) {
}
DownloadManagerImpl::~DownloadManagerImpl() {
@@ -656,10 +655,6 @@ void DownloadManagerImpl::GetAllDownloads(DownloadVector* downloads) {
}
}
-void DownloadManagerImpl::MockDownloadOpenForTesting() {
- open_enabled_ = false;
-}
-
void DownloadManagerImpl::OpenDownload(DownloadItemImpl* download) {
int num_unopened = 0;
for (DownloadMap::iterator it = downloads_.begin();
@@ -671,7 +666,7 @@ void DownloadManagerImpl::OpenDownload(DownloadItemImpl* download) {
}
RecordOpensOutstanding(num_unopened);
- if (delegate_ && open_enabled_) // Some tests disable OpenDownload().
+ if (delegate_)
delegate_->OpenDownload(download);
}
« no previous file with comments | « content/browser/download/download_manager_impl.h ('k') | content/public/browser/download_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698