Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2276)

Unified Diff: chrome/browser/download/download_test_file_activity_observer.h

Issue 12047039: download: Remove DownloadManager::MockDownloadOpenForTesting (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and comment fix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_test_file_activity_observer.h
diff --git a/chrome/browser/download/download_test_file_chooser_observer.h b/chrome/browser/download/download_test_file_activity_observer.h
similarity index 56%
rename from chrome/browser/download/download_test_file_chooser_observer.h
rename to chrome/browser/download/download_test_file_activity_observer.h
index 9380065e581a7824531af38102fb47a0b2ec80e0..736b9fd005ce26219a8d63b898f90a499dc655eb 100644
--- a/chrome/browser/download/download_test_file_chooser_observer.h
+++ b/chrome/browser/download/download_test_file_activity_observer.h
@@ -2,27 +2,24 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TEST_FILE_CHOOSER_OBSERVER_H_
-#define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TEST_FILE_CHOOSER_OBSERVER_H_
+#ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TEST_FILE_ACTIVITY_OBSERVER_H_
+#define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TEST_FILE_ACTIVITY_OBSERVER_H_
#include "base/memory/ref_counted.h"
class Profile;
-namespace internal {
-class MockFileChooserDownloadManagerDelegate;
-}
-
-// Observes and overrides file chooser activity for a profile. By default, once
-// attached to a profile, this class overrides the default file chooser by
-// replacing the ChromeDownloadManagerDelegate associated with |profile|.
+// Observes and overrides file chooser dialog and open activity for a profile.
+// By default, once attached to a profile, this class overrides the default file
+// related activity by replacing the ChromeDownloadManagerDelegate associated
+// with |profile|.
// NOTE: Again, this overrides the ChromeDownloadManagerDelegate for |profile|.
-class DownloadTestFileChooserObserver {
+class DownloadTestFileActivityObserver {
public:
// Attaches to |profile|. By default file chooser dialogs will be disabled
// once attached. Call EnableFileChooser() to re-enable.
- explicit DownloadTestFileChooserObserver(Profile* profile);
- ~DownloadTestFileChooserObserver();
+ explicit DownloadTestFileActivityObserver(Profile* profile);
+ ~DownloadTestFileActivityObserver();
// Sets whether the file chooser dialog is enabled. If |enable| is false, any
// attempt to display a file chooser dialog will cause the download to be
@@ -35,8 +32,9 @@ class DownloadTestFileChooserObserver {
bool TestAndResetDidShowFileChooser();
private:
- scoped_refptr<internal::MockFileChooserDownloadManagerDelegate>
- test_delegate_;
+ class MockDownloadManagerDelegate;
+
+ scoped_refptr<MockDownloadManagerDelegate> test_delegate_;
};
-#endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TEST_FILE_CHOOSER_OBSERVER_H_
+#endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TEST_FILE_ACTIVITY_OBSERVER_H_
« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/download/download_test_file_activity_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698