download: Remove DownloadManager::MockDownloadOpenForTesting

chrome/browser/download/download_test_file_chooser_observer.cc

Index: chrome/browser/download/download_test_file_chooser_observer.cc
diff --git a/chrome/browser/download/download_test_file_chooser_observer.cc b/chrome/browser/download/download_test_file_chooser_observer.cc
index 3a0ddf29dbdb91bd45eb4a166192aa40267f2e17..919e19b58f52772b46ace5f5a1a87b55544344a0 100644
--- a/chrome/browser/download/download_test_file_chooser_observer.cc
+++ b/chrome/browser/download/download_test_file_chooser_observer.cc
@@ -50,6 +50,8 @@ class MockFileChooserDownloadManagerDelegate
                    (file_chooser_enabled_ ? suggested_path : FilePath())));
   }
 
+  virtual void OpenDownload(content::DownloadItem* item) OVERRIDE {}

[Randy Smith (Not in Mondays), 2013/01/23 21:23:34]

Is this class being used in DownloadTest.AutoOpen?  I don't see how it would be.
 

Mocking out opening is also not really part of this class' concept.  I think the
right thing is to create a new class in
chrome/browser/download/download_browsertest.cc derived from
ChromeDownloadManagerDelegate that just mocks out Open(), and use it in that
test only.

[hashimoto, 2013/01/24 05:52:31]

Both DownloadTest.AutoOpen and DownloadExtensionTest.DownloadExtensionTest_Open
are using this class by instantiating DownloadTestFileChooserObserver in their
test fixture classes.
Since this class is the only user of
DownloadService::SetDownloadManagerDelegateForTesting, and is responsible to
'mock' user-facing download related behavior, I thought this class is the place
where this empty OpenDownload() should be. (Perhaps, it should be better renamed
to MockDownloadManagerDelegate or something.)
Since DownloadTestFileChooserObserver is already setup in
DownloadTest:SetUpOnMainThread for all tests under DownloadTest, I think adding
one empty method here is quite simpler than setting up a new
DownloadManagerDelegate.
The same goes for DownloadExtensionTest.

Thoughts?

+
  private:
   virtual ~MockFileChooserDownloadManagerDelegate() {}
 
@@ -77,4 +79,3 @@ void DownloadTestFileChooserObserver::EnableFileChooser(bool enable) {
 bool DownloadTestFileChooserObserver::TestAndResetDidShowFileChooser() {
   return test_delegate_->TestAndResetDidShowFileChooser();
 }
-