Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 1204643003: [test] Teach test runner about whether novfp3 is on or off (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Teach test runner about whether novfp3 is on or off BUG=none R=machenbach@chromium.org LOG=n Committed: https://crrev.com/22b691ba0ecca783ffea67273bfbc5b2bf2c92d3 Cr-Commit-Position: refs/heads/master@{#29221}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tools/run-deopt-fuzzer.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/run-tests.py View 1 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-06-23 06:57:43 UTC) #1
Michael Achenbach
lgtm
5 years, 6 months ago (2015-06-23 07:20:41 UTC) #2
Michael Achenbach
Maybe add some tests to the mjsunit.status file directly: Skip: asm/embenchen/box2d asm/embenchen/zlib asm/embenchen/memops asm/embenchen/lua_binarytrees https://codereview.chromium.org/1204643003/diff/1/tools/run-tests.py ...
5 years, 6 months ago (2015-06-23 08:47:48 UTC) #3
jochen (gone - plz use gerrit)
ptal
5 years, 6 months ago (2015-06-23 08:54:37 UTC) #4
Michael Achenbach
lgtm
5 years, 6 months ago (2015-06-23 09:19:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204643003/20001
5 years, 6 months ago (2015-06-23 09:26:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-23 09:43:12 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 09:43:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22b691ba0ecca783ffea67273bfbc5b2bf2c92d3
Cr-Commit-Position: refs/heads/master@{#29221}

Powered by Google App Engine
This is Rietveld 408576698