Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1204623002: Expose Map/Set methods through the API (Closed)

Created:
5 years, 6 months ago by adamk
Modified:
5 years, 6 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Expose Map/Set methods through the API Map: get, set, has, delete, clear Set: add, has, delete, clear All except clear are implemented as calls into collection.js. Note that some of these shadow methods of v8::Object. It's unclear how confusing that's going to be: on the one hand, it seems likely that most operations you would want to do on a Map or Set are these. On the other, generic code could get confused if it somehow gets ahold of a variable that happens to be C++-typed as a v8::Map or v8::Set. BUG=v8:3340 LOG=y Committed: https://crrev.com/df472240285a93f25edac20100db2240fae5c7c6 Cr-Commit-Position: refs/heads/master@{#29237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -7 lines) Patch
M include/v8.h View 2 chunks +17 lines, -0 lines 0 comments Download
M src/api.cc View 2 chunks +112 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/collection.js View 2 chunks +13 lines, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-collections.cc View 2 chunks +16 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +54 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
adamk
5 years, 6 months ago (2015-06-23 00:41:11 UTC) #2
jochen (gone - plz use gerrit)
api lgtm
5 years, 6 months ago (2015-06-23 14:57:06 UTC) #3
arv (Not doing code reviews)
LGTM
5 years, 6 months ago (2015-06-23 15:01:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204623002/1
5 years, 6 months ago (2015-06-23 15:12:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 15:14:13 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 15:14:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df472240285a93f25edac20100db2240fae5c7c6
Cr-Commit-Position: refs/heads/master@{#29237}

Powered by Google App Engine
This is Rietveld 408576698