Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java

Issue 12045088: Issue 8051. Make extended exit codes optional. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/java/com/google/dart/compiler/DartCompiler.java ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java
diff --git a/compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java b/compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java
index eed2876548dca4491390e3461ee6786f62082c57..bbabf4a2a35b36189a1d81b7e433231545722fc5 100644
--- a/compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java
+++ b/compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java
@@ -44,7 +44,7 @@ public class UnitTestBatchRunner {
// TODO(zundel): These are shell script cmdlines: be smarter about quoted strings.
String[] args = line.trim().split("\\s+");
Result result = toolInvocation.invoke(args);
- boolean resultPass = result.code >= DartCompiler.RESULT_ERRORS;
+ boolean resultPass = result.code < DartCompiler.RESULT_ERRORS;
if (resultPass) {
testsFailed++;
}
« no previous file with comments | « compiler/java/com/google/dart/compiler/DartCompiler.java ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698