Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java

Issue 12045080: Issue 8108. Don't record 'deprecated' warnings in integration test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
index 50e024b7eb89418ac78247709adc7ce646597f5b..a106aa8e83962714eef982b8840902634b97986b 100644
--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
@@ -1573,8 +1573,7 @@ public class IncrementalCompilation2Test extends CompilerTestCase {
""));
// do compile, no errors expected
compile();
- // Bug #8108- Complaining about deprecated dart:html APIs
- //assertErrors(errors);
+ assertErrors(errors);
// validate types
DartUnit unit = units.get(APP);
assertNotNull(unit);
@@ -1842,6 +1841,10 @@ public class IncrementalCompilation2Test extends CompilerTestCase {
@Override
public void onError(DartCompilationError event) {
+ // ignore deprecated
+ if (event.getErrorCode() == TypeErrorCode.DEPRECATED_ELEMENT) {
+ return;
+ }
// Remember errors only between unitAboutToCompile/unitCompiled.
Source source = event.getSource();
if (source != null && compilingUris.contains(source.getUri())) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698