Issue 12045067: Revert 177293

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12045067: Revert 177293 (Closed)

Created:
7 years, 11 months ago by robertshield

Modified:
7 years, 11 months ago

Reviewers:
robertshield

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/branches/1312/src/

Visibility:
Public.

Revert 177293 > Merge 175182 > > Cause Chrome Frame to follow the fast shutdown path, which cleans up infobars and avoids a crash on shutdown. > > > > Chrome Frame Android were the only remaining things in Chrome that appear not to use the fast shutdown path and afaict the non-fast shutdown path no longer works. > > > > BUG=148398 > > TEST=Visit hyves.nl or some other CF-aware site that pops up a translation bar in CF. Close IE, using an attached debugger or your mechanism of choice observe that Chrome doesn't crash during shutdown. > > TBR=sky > > > > > > Review URL: https://chromiumcodereview.appspot.com/11746029 > > TBR=robertshield@chromium.org > Review URL: https://codereview.chromium.org/11956034 TBR=robertshield@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178591

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/chrome_content_browser_client.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/views/external_tab_container_win.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 1 (0 generated)