Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 12045062: Merge 140385 (Closed)

Created:
7 years, 8 months ago by tkent
Modified:
7 years, 8 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 140385 > Date selection from calendar picker should dispatch 'input' event in addition to 'change' event > https://bugs.webkit.org/show_bug.cgi?id=107427 > > Reviewed by Kentaro Hara. > > Source/WebCore: > > According to the specification and Opera's behavior, we should dispatch > not only 'change' event but also 'input' event when a user chooses a > date from the calender picker. > > http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#common-event-behaviors > > When the user agent changes the element's value on behalf of the user > > (e.g. as part of a form prefilling feature), the user agent must follow > > these steps: > > 1. If the input event applies, queue a task to fire a simple event > > that bubbles named input at the input element. > > 2. If the change event applies, queue a task to fire a simple event > > that bubbles named change at the input element. > > Tests: platform/chromium/fast/forms/calendar-picker/date-picker-events.html > platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events.html > > * html/InputType.cpp: > (WebCore::InputType::setValue): Add DispatchInputAndChangeEvent support. > * html/BaseChooserOnlyDateAndTimeInputType.cpp: > (WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue): > Use DispatchInputAndChangeEvent, not DispatchChangeEvent. > * html/BaseMultipleFieldsDateAndTimeInputType.cpp: > (WebCore::BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue): > Ditto. > > LayoutTests: > > * platform/chromium/fast/forms/calendar-picker/date-picker-events-expected.txt: Added. > * platform/chromium/fast/forms/calendar-picker/date-picker-events.html: Added. > * platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events-expected.txt: Added. > * platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events.html: Added. > TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140651

Patch Set 1 #

Messages

Total messages: 1 (0 generated)
tkent
7 years, 8 months ago (2013-01-24 05:46:30 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698