Issue 12045039: Add googleurl.gyp to make it possible to build using gyp tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12045039: Add googleurl.gyp to make it possible to build using gyp tool. (Closed)

Created:
7 years, 11 months ago by tfarina

Modified:
7 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://google-url.googlecode.com/svn/trunk/

Visibility:
Public.

Add googleurl.gyp to make it possible to build using gyp tool. R=brettw@chromium.org] Signed-off-by: Thiago Farina <tfarina@chromium.org>;

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -0 lines)			Patch
	A	googleurl.gyp	View		1 chunk	+108 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

tfarina

Hi Brett, could you review this to me? I tested this patch with: $ ./build/gyp_chromium ...

7 years, 11 months ago (2013-01-23 03:34:06 UTC) #1

tfarina

On 2013/01/24 06:11:46, brettw wrote: > lgtm Brett I can't gcl commit this, it gives ...

7 years, 11 months ago (2013-01-24 13:17:15 UTC) #3

brettw

Committed as googleurl@182. Can you pull deps into Chrome?

7 years, 11 months ago (2013-01-24 21:47:09 UTC) #4

tfarina

7 years, 11 months ago (2013-01-24 22:55:15 UTC) #5

Message was sent while issue was closed.

Done. Uploaded the DEPS change at https://codereview.chromium.org/12036093/