Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5059)

Unified Diff: chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc

Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Android link error Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc
diff --git a/chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc b/chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc
index 1532136fc71102f1b442beac2e1eb3fcf3d46eaf..736ddfe847902905fa593625be368b9d9fdf8529 100644
--- a/chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc
+++ b/chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc
@@ -52,19 +52,21 @@ class WebContentsModalDialogCloseTest : public WebContentsModalDialog {
content::WebContents* web_contents_;
};
-TEST_F(WebContentsModalDialogManagerTest, ConstrainedWindows) {
+TEST_F(WebContentsModalDialogManagerTest, WebContentsModalDialogs) {
WebContentsModalDialogCloseTest window(web_contents());
window.close_count = 0;
WebContentsModalDialogManager* web_contents_modal_dialog_manager =
WebContentsModalDialogManager::FromWebContents(web_contents());
+ WebContentsModalDialogManager::TestApi test_api(
+ web_contents_modal_dialog_manager);
+
+ test_api.ResetNativeManager(NULL);
const int kWindowCount = 4;
for (int i = 0; i < kWindowCount; i++)
web_contents_modal_dialog_manager->AddDialog(&window);
EXPECT_EQ(window.close_count, 0);
- WebContentsModalDialogManager::TestApi test_api(
- web_contents_modal_dialog_manager);
test_api.CloseAllDialogs();
EXPECT_EQ(window.close_count, kWindowCount);
}

Powered by Google App Engine
This is Rietveld 408576698