chrome/browser/ui/views/login_prompt_views.cc - Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/login_prompt_views.cc

Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Android link error Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc ('k') | chrome/browser/ui/views/native_constrained_window_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/login_prompt_views.cc

diff --git a/chrome/browser/ui/views/login_prompt_views.cc b/chrome/browser/ui/views/login_prompt_views.cc

index 227b5064c26fe3020084971b476a65c8db5b9d27..b1c32b7dff5fddfe4f80a77923c8ace064d06b16 100644

--- a/chrome/browser/ui/views/login_prompt_views.cc

+++ b/chrome/browser/ui/views/login_prompt_views.cc

@@ -135,7 +135,7 @@ class LoginHandlerViews : public LoginHandler,

// will occur via an InvokeLater on the UI thread, which is guaranteed

// to happen after this is called (since this was InvokeLater'd first).

WebContents* requesting_contents = GetWebContentsForLogin();

- SetDialog(new ConstrainedWindowViews(requesting_contents, this));

+ SetDialog(ConstrainedWindowViews::Create(requesting_contents, this));

NotifyAuthNeeded();

}