chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc - Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Android link error Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

diff --git a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

index 3a13d3fc3b7aacbf23a4a356f443774b7b28d17e..0defe8cd07327ee1eea9f8c2c2731ee854a5f78c 100644

--- a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

+++ b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

@@ -198,7 +198,7 @@ ConstrainedWebDialogDelegate* CreateConstrainedWebDialog(

new ConstrainedWebDialogDelegateViewViews(

browser_context, delegate, tab_delegate);

WebContentsModalDialog* web_contents_modal_dialog =

- new ConstrainedWindowViews(web_contents, constrained_delegate);

+ ConstrainedWindowViews::Create(web_contents, constrained_delegate);

constrained_delegate->set_window(web_contents_modal_dialog);

return constrained_delegate;

}

« no previous file with comments | « chrome/browser/ui/views/collected_cookies_views.cc ('k') | chrome/browser/ui/views/constrained_window_views.h » ('j') | no next file with comments »