chrome/browser/ui/browser_command_controller_browsertest.cc - Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller_browsertest.cc

Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm » ('j') | chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_command_controller_browsertest.cc

diff --git a/chrome/browser/ui/browser_command_controller_browsertest.cc b/chrome/browser/ui/browser_command_controller_browsertest.cc

index 930319b30673f9a97dee4858588e0d35899d4834..1f71986976be3a6086a13d3573c2ebd3bcc4eb4a 100644

--- a/chrome/browser/ui/browser_command_controller_browsertest.cc

+++ b/chrome/browser/ui/browser_command_controller_browsertest.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/test/base/in_process_browser_test.h"

+#include "content/public/test/test_utils.h"

typedef InProcessBrowserTest BrowserCommandControllerBrowserTest;

@@ -35,5 +36,6 @@ IN_PROC_BROWSER_TEST_F(BrowserCommandControllerBrowserTest, DisableFind) {

// Closing the constrained window should reenable it.

delegate->Cancel();

+ content::RunAllPendingInMessageLoop();

EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FIND));

}