Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 12045030: Merge 177774 (Closed)

Created:
7 years, 11 months ago by Yusuf
Modified:
7 years, 11 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Merge 177774 > Start sending synthetic keyevents for enter and tab in Android IME > > After sdk 15 Android framework no longer sends keyevents for enter and tab > and the current spec says the dispatchKeyEvent call should only be used for > hardware keyboard. So we stop calling ImeAdapter with dispathKeyEvent if the > keyboard is not connected and also start sending these keyevents when a > they are committed as a single character > > BUG=166233 > > > Review URL: https://chromiumcodereview.appspot.com/11914003 TBR=yusufo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -57 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +8 lines, -11 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java View 8 chunks +53 lines, -46 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Yusuf
7 years, 11 months ago (2013-01-22 21:04:23 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698