Issue 12045029: Add CQ Top Score dashboard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12045029: Add CQ Top Score dashboard. (Closed)

Created:
7 years, 11 months ago by M-A Ruel

Modified:
7 years, 11 months ago

Reviewers:
csharp

CC:
chromium-reviews, cmp+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/chromium-status

Visibility:
Public.

More Reviews

Description

Add CQ Top Score dashboard. Gamify ALL the things! R=csharp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178161

Patch Set 2 : Add "Top scores" link to all CQ pags #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+338 lines, -1 line)			Patch
M	app.yaml	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	commit_queue.py	View		2 chunks	+36 lines, -0 lines	0 comments	Download
M	main.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	static/third_party/FONTLOG.txt	View		1 chunk	+69 lines, -0 lines	0 comments	Download
A	static/third_party/LICENSE.txt	View		1 chunk	+94 lines, -0 lines	0 comments	Download
A	static/third_party/PressStart2P.ttf	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	stylesheets/cq_top_score.css	View		1 chunk	+94 lines, -0 lines	0 comments	Download
M	templates/cq_owner.html	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	templates/cq_owners.html	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	templates/cq_top_score.html	View		1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csharp

lgtm awesome https://codereview.chromium.org/12045029/diff/1/templates/cq_top_score.html File templates/cq_top_score.html (right): https://codereview.chromium.org/12045029/diff/1/templates/cq_top_score.html#newcode27 templates/cq_top_score.html:27: 10 POINTS FOR CQ IN THE PAST ...

7 years, 11 months ago (2013-01-22 21:08:03 UTC) #2

M-A Ruel

7 years, 11 months ago (2013-01-22 23:54:34 UTC) #3

I've modified both templates/cq_owners.html and templates/cq_owner.html to add a
link to Top scores at the very bottom.

https://codereview.chromium.org/12045029/diff/1/templates/cq_top_score.html
File templates/cq_top_score.html (right):

https://codereview.chromium.org/12045029/diff/1/templates/cq_top_score.html#n...
templates/cq_top_score.html:27: 10 POINTS FOR CQ IN THE PAST 24 HOURS<br>
On 2013/01/22 21:08:03, csharp wrote:
> Nit: Have the legend at the top of the page instead

I'd prefer to keep it at the bottom to keep the dramatic effect. Another option
is to limit it to 100 items but I felt it was interesting to not limit it.

Expand Messages | Collapse Messages

Issue 12045029: Add CQ Top Score dashboard. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add "Top scores" link to all CQ pags #

Messages