Issue 12045026: net: add two Google backup pins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12045026: net: add two Google backup pins. (Closed)

Created:
7 years, 11 months ago by agl

Modified:
7 years, 11 months ago

Reviewers:
palmer

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Chris Evans

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net: add two Google backup pins. (Details will be distributed internally to reviewers.) BUG=171444 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178657

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -0 lines)			Patch
M	net/base/transport_security_state_static.h	View	2 chunks	+10 lines, -0 lines	1 comment	Download
M	net/base/transport_security_state_static.certs	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	net/base/transport_security_state_static.json	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

palmer

lgtm https://codereview.chromium.org/12045026/diff/1/net/base/transport_security_state_static.certs File net/base/transport_security_state_static.certs (right): https://codereview.chromium.org/12045026/diff/1/net/base/transport_security_state_static.certs#newcode80 net/base/transport_security_state_static.certs:80: sha1/fVujyo43ZR18ccPjt3TN6XsbWUM= These are good. https://codereview.chromium.org/12045026/diff/1/net/base/transport_security_state_static.h File net/base/transport_security_state_static.h (right): ...

7 years, 11 months ago (2013-01-22 19:08:07 UTC) #2

commit-bot: I haz the power

7 years, 11 months ago (2013-01-24 21:33:18 UTC) #3

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages