Issue 12045017: Incorrect ARM assembly in MacroAssembler::TestJSArrayForAllocationSiteInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12045017: Incorrect ARM assembly in MacroAssembler::TestJSArrayForAllocationSiteInfo (Closed)

Created:
7 years, 11 months ago by mvstanton

Modified:
7 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Incorrect ARM assembly in MacroAssembler::TestJSArrayForAllocationSiteInfo Restored test code in allocation-site-info.js that was failing on ARM because of this bug. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13462

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -35 lines)			Patch
	M	src/arm/macro-assembler-arm.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	M	test/mjsunit/allocation-site-info.js	View		1 chunk	+44 lines, -32 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Yang, here is the fix for the issue seen in the tests last night ...

7 years, 11 months ago (2013-01-22 10:16:16 UTC) #1

Yang

7 years, 11 months ago (2013-01-22 10:23:42 UTC) #2

On 2013/01/22 10:16:16, mvstanton wrote:
> Hi Yang, here is the fix for the issue seen in the tests last night on ARM.
I've
> tested in the ARM simulator now.
> Thanks,
> --Michael

LGTM.

Expand Messages | Collapse Messages