Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1204483003: Remove usage of S.p.charCodeAt from uri.js (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove usage of S.p.charCodeAt from uri.js We were using both String.prototype.charCodeAt and String.prototype.charAt. BUG=v8:4224 LOG=N R=adamk, littledan CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/b5adc2f6b41e0f21db5b39ccaf6c4c487e29eda5 Cr-Commit-Position: refs/heads/master@{#29208}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M src/uri.js View 6 chunks +21 lines, -13 lines 1 comment Download
M test/mjsunit/uri.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL https://codereview.chromium.org/1204483003/diff/1/src/uri.js File src/uri.js (right): https://codereview.chromium.org/1204483003/diff/1/src/uri.js#newcode167 src/uri.js:167: uri = TO_STRING_INLINE(uri); The spec calls this as ...
5 years, 6 months ago (2015-06-22 21:45:35 UTC) #1
adamk
lgtm
5 years, 6 months ago (2015-06-22 21:47:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204483003/1
5 years, 6 months ago (2015-06-22 22:27:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 23:43:21 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 23:43:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5adc2f6b41e0f21db5b39ccaf6c4c487e29eda5
Cr-Commit-Position: refs/heads/master@{#29208}

Powered by Google App Engine
This is Rietveld 408576698