Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1204473005: DevTools: Tweak v8 code objects name parsing. (Closed)

Created:
4 years, 10 months ago by alph
Modified:
4 years, 10 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Tweak v8 code objects name parsing. BUG=406277 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197667

Patch Set 1 #

Total comments: 2

Patch Set 2 : added a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -49 lines) Patch
A LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names.html View 1 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-js-samping-codeobject-names-expected.txt View 1 1 chunk +14 lines, -0 lines 0 comments Download
M Source/devtools/front_end/common/ParsedURL.js View 1 chunk +11 lines, -10 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineJSProfile.js View 1 2 chunks +64 lines, -39 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alph
4 years, 10 months ago (2015-06-23 16:59:13 UTC) #2
yurys
lgtm, please add a test for the name parser. https://codereview.chromium.org/1204473005/diff/1/Source/devtools/front_end/timeline/TimelineJSProfile.js File Source/devtools/front_end/timeline/TimelineJSProfile.js (right): https://codereview.chromium.org/1204473005/diff/1/Source/devtools/front_end/timeline/TimelineJSProfile.js#newcode366 Source/devtools/front_end/timeline/TimelineJSProfile.js:366: ...
4 years, 10 months ago (2015-06-23 17:09:56 UTC) #3
yurys
lgtm, please add a test for the name parser.
4 years, 10 months ago (2015-06-23 17:09:57 UTC) #4
alph
https://codereview.chromium.org/1204473005/diff/1/Source/devtools/front_end/timeline/TimelineJSProfile.js File Source/devtools/front_end/timeline/TimelineJSProfile.js (right): https://codereview.chromium.org/1204473005/diff/1/Source/devtools/front_end/timeline/TimelineJSProfile.js#newcode366 Source/devtools/front_end/timeline/TimelineJSProfile.js:366: if (!tokens || tokens.length < 3) { On 2015/06/23 ...
4 years, 10 months ago (2015-06-23 17:38:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204473005/20001
4 years, 10 months ago (2015-06-23 17:38:39 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 18:44:22 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197667

Powered by Google App Engine
This is Rietveld 408576698