Issue 1204473003: Fixed the copy link issue in the sad tab view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1204473003: Fixed the copy link issue in the sad tab view (Closed)

Created:
5 years, 6 months ago by farshid

Modified:
5 years, 2 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixed the copy link issue in the sad tab view [Mac] This patch fixes a minor issue which was not populating the link in the HyperlinkTextView when creating the "suggestions" link. BUG=484130 TEST=launch chrome, navigate to a webpage and then go to chrome://kill. then right click on the suggestions link and select "copy link" instead of it being empty it goes to kCrashReasonURL

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	AUTHORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

farshid

5 years, 6 months ago (2015-06-24 03:25:50 UTC) #3

farshid.ghods@gmail.com changed reviewers:
+ thakis@chromium.org

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages