Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1204453002: Devtools: Create layout editor experiment (Closed)

Created:
4 years, 10 months ago by sergeyv
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Create layout editor experiment BUG=501896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197716

Patch Set 1 #

Patch Set 2 : Show handles for padding #

Patch Set 3 : #

Total comments: 24

Patch Set 4 : Address comments #

Total comments: 4

Patch Set 5 : Address comments#2 #

Total comments: 14

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -3 lines) Patch
M Source/core/core.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorHighlight.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorHighlight.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlayPage.html View 1 2 3 4 5 5 chunks +44 lines, -0 lines 0 comments Download
A Source/core/inspector/LayoutEditor.h View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download
A Source/core/inspector/LayoutEditor.cpp View 1 2 3 4 5 1 chunk +111 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/InspectorOverlayImpl.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 2 3 4 5 4 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
sergeyv
4 years, 10 months ago (2015-06-23 13:08:21 UTC) #2
dgozman
Rename to LayoutEditor/showLayoutEditor. https://codereview.chromium.org/1204453002/diff/40001/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/1204453002/diff/40001/Source/core/inspector/InspectorDOMAgent.cpp#newcode1227 Source/core/inspector/InspectorDOMAgent.cpp:1227: PassOwnPtr<InspectorHighlightConfig> InspectorDOMAgent::highlightConfigFromInspectorObject(ErrorString* errorString, JSONObject* highlightInspectorObject) I ...
4 years, 10 months ago (2015-06-23 14:00:30 UTC) #3
sergeyv
https://codereview.chromium.org/1204453002/diff/40001/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/1204453002/diff/40001/Source/core/inspector/InspectorDOMAgent.cpp#newcode1227 Source/core/inspector/InspectorDOMAgent.cpp:1227: PassOwnPtr<InspectorHighlightConfig> InspectorDOMAgent::highlightConfigFromInspectorObject(ErrorString* errorString, JSONObject* highlightInspectorObject) On 2015/06/23 14:00:30, dgozman ...
4 years, 10 months ago (2015-06-23 16:36:53 UTC) #4
dgozman
https://codereview.chromium.org/1204453002/diff/60001/Source/core/inspector/InspectorHighlight.cpp File Source/core/inspector/InspectorHighlight.cpp (right): https://codereview.chromium.org/1204453002/diff/60001/Source/core/inspector/InspectorHighlight.cpp#newcode470 Source/core/inspector/InspectorHighlight.cpp:470: PassOwnPtr<InspectorHighlightConfig> InspectorHighlight::highlightConfigFromInspectorObject(JSONObject* highlightInspectorObject) RefPtr<JSONObject> https://codereview.chromium.org/1204453002/diff/60001/Source/core/inspector/InspectorHighlight.cpp#newcode498 Source/core/inspector/InspectorHighlight.cpp:498: PassOwnPtr<InspectorHighlightConfig> InspectorHighlight::highlightConfigWithColors(const RefPtr<JSONObject>* ...
4 years, 10 months ago (2015-06-23 16:45:07 UTC) #5
dgozman
lgtm https://codereview.chromium.org/1204453002/diff/80001/Source/core/inspector/InspectorOverlayPage.html File Source/core/inspector/InspectorOverlayPage.html (right): https://codereview.chromium.org/1204453002/diff/80001/Source/core/inspector/InspectorOverlayPage.html#newcode577 Source/core/inspector/InspectorOverlayPage.html:577: if (highlight.wysiwygInfo) wysiwyg https://codereview.chromium.org/1204453002/diff/80001/Source/core/inspector/InspectorOverlayPage.html#newcode633 Source/core/inspector/InspectorOverlayPage.html:633: function showWYSIWYGEditor(info) wysiwyg ...
4 years, 10 months ago (2015-06-23 17:13:56 UTC) #6
sergeyv
https://codereview.chromium.org/1204453002/diff/80001/Source/core/inspector/InspectorOverlayPage.html File Source/core/inspector/InspectorOverlayPage.html (right): https://codereview.chromium.org/1204453002/diff/80001/Source/core/inspector/InspectorOverlayPage.html#newcode577 Source/core/inspector/InspectorOverlayPage.html:577: if (highlight.wysiwygInfo) On 2015/06/23 17:13:55, dgozman wrote: > wysiwyg ...
4 years, 10 months ago (2015-06-23 17:21:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204453002/100001
4 years, 10 months ago (2015-06-23 17:23:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/36155)
4 years, 10 months ago (2015-06-23 17:29:45 UTC) #12
pfeldman
4 years, 10 months ago (2015-06-24 08:33:56 UTC) #13
pfeldman
lgtm
4 years, 10 months ago (2015-06-24 08:34:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204453002/100001
4 years, 10 months ago (2015-06-24 08:34:33 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 08:38:35 UTC) #17
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197716

Powered by Google App Engine
This is Rietveld 408576698