Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: sky/sdk/lib/rendering/README.md

Issue 1204373003: Fix nits in the README.md from abarth's review. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/rendering/README.md
diff --git a/sky/sdk/lib/rendering/README.md b/sky/sdk/lib/rendering/README.md
index 3570d0ac9b6246450191cf44d935d2015e671682..8cd5c961ccce8d9ead528b563b68d228856e9a97 100644
--- a/sky/sdk/lib/rendering/README.md
+++ b/sky/sdk/lib/rendering/README.md
@@ -137,9 +137,9 @@ Writing new subclasses
### The RenderObject contract
If you want to define a `RenderObject` that uses a new coordinate
-system, then you have to inherit straight from `RenderObject`.
-Examples of doing this can be found in [`RenderBox`](box.dart), which
-deals in rectangles in cartesian space, and in the [sector_layout.dart
+system, then you should inherit straight from `RenderObject`. Examples
+of doing this can be found in [`RenderBox`](box.dart), which deals in
+rectangles in cartesian space, and in the [sector_layout.dart
example](../../../examples/rendering/sector_layout.dart), which
implements a toy model based on polar coordinates. The `RenderView`
class, which is used internally to adapt from the host system to this
@@ -159,7 +159,7 @@ A subclass of `RenderObject` must fulfill the following contract:
appropriately.
* Layout constraints must be expressed in a Constraints subclass. This
- subclass must implement operator== (and hashCode).
+ subclass must implement `operator==` (and `hashCode`).
* Whenever the layout needs updating, the `markNeedsLayout()` method
should be called.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698