Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1204353004: Fix form association behavior when a form and a control with form= are removed from a document toge… (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix form association behavior when a form and a control with form= are removed from a document together. We missed to call resetFormOwner() if they are in the single sub-tree even after they were removed from the document. BUG=492981 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197887

Patch Set 1 #

Total comments: 3

Patch Set 2 : Don't add an assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M LayoutTests/fast/forms/form-attribute.html View 2 chunks +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/form-attribute-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/FormAssociatedElement.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1037683002 Patch 1

Messages

Total messages: 9 (2 generated)
tkent
Keishi, would you review this please?
4 years, 10 months ago (2015-06-26 01:13:51 UTC) #2
tkent
https://codereview.chromium.org/1204353004/diff/1/Source/core/html/FormAssociatedElement.cpp File Source/core/html/FormAssociatedElement.cpp (right): https://codereview.chromium.org/1204353004/diff/1/Source/core/html/FormAssociatedElement.cpp#newcode105 Source/core/html/FormAssociatedElement.cpp:105: ASSERT(!m_form); Some tests hit this. Investigating...
4 years, 10 months ago (2015-06-26 02:01:44 UTC) #3
tkent
https://codereview.chromium.org/1204353004/diff/1/Source/core/html/FormAssociatedElement.cpp File Source/core/html/FormAssociatedElement.cpp (right): https://codereview.chromium.org/1204353004/diff/1/Source/core/html/FormAssociatedElement.cpp#newcode105 Source/core/html/FormAssociatedElement.cpp:105: ASSERT(!m_form); On 2015/06/26 02:01:44, tkent wrote: > Some tests ...
4 years, 10 months ago (2015-06-26 03:49:16 UTC) #4
tkent
https://codereview.chromium.org/1204353004/diff/1/Source/core/html/FormAssociatedElement.cpp File Source/core/html/FormAssociatedElement.cpp (right): https://codereview.chromium.org/1204353004/diff/1/Source/core/html/FormAssociatedElement.cpp#newcode105 Source/core/html/FormAssociatedElement.cpp:105: ASSERT(!m_form); On 2015/06/26 03:49:16, tkent wrote: > On 2015/06/26 ...
4 years, 10 months ago (2015-06-26 03:51:54 UTC) #5
keishi
lgtm
4 years, 10 months ago (2015-06-26 03:59:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204353004/20001
4 years, 10 months ago (2015-06-26 04:33:29 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-26 04:50:03 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197887

Powered by Google App Engine
This is Rietveld 408576698