Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1204283002: Add lua scripts for generating n-grams from SKPs (Closed)

Created:
5 years, 6 months ago by borenet
Modified:
5 years, 6 months ago
Reviewers:
jcgregorio, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add lua scripts for generating n-grams from SKPs BUG=skia:3840 Committed: https://skia.googlesource.com/skia/+/93558dc74be4a92a8dfba87fcffd4441a37c0fc8

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
M Makefile View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/lua/ngrams.lua View 1 1 chunk +62 lines, -0 lines 0 comments Download
A tools/lua/ngrams_aggregate.lua View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
borenet
5 years, 6 months ago (2015-06-25 14:28:10 UTC) #2
jcgregorio
lgtm
5 years, 6 months ago (2015-06-25 14:39:58 UTC) #3
jcgregorio
On 2015/06/25 at 14:39:58, jcgregorio wrote: > lgtm Are you sure you want the scripts ...
5 years, 6 months ago (2015-06-25 14:41:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204283002/20001
5 years, 6 months ago (2015-06-25 14:41:46 UTC) #6
rmistry
On 2015/06/25 at 14:41:38, jcgregorio wrote: > On 2015/06/25 at 14:39:58, jcgregorio wrote: > > ...
5 years, 6 months ago (2015-06-25 14:42:31 UTC) #7
borenet
On 2015/06/25 at 14:41:38, jcgregorio wrote: > On 2015/06/25 at 14:39:58, jcgregorio wrote: > > ...
5 years, 6 months ago (2015-06-25 14:42:53 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 14:47:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/93558dc74be4a92a8dfba87fcffd4441a37c0fc8

Powered by Google App Engine
This is Rietveld 408576698