Implement FetchDataLoader::createLoaderAsStream()

Implement FetchDataLoader::createLoaderAsStream()

For replacing StreamUploader in RespondWithObserver.cpp.

BUG=480746
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197818

[hiroshige, 2015-06-25 09:46:37]

hiroshige@chromium.org changed reviewers:
+ yhirano@chromium.org

[hiroshige, 2015-06-25 10:11:49]

PTAL.

[yhirano, 2015-06-25 10:53:33]

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
File Source/modules/fetch/FetchDataLoader.cpp (right):

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
Source/modules/fetch/FetchDataLoader.cpp:249: bool needToFlush = false;
This variable should be defined out of the loop.

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
Source/modules/fetch/FetchDataLoader.cpp:254: m_reader->endRead(available);
needToFlush = true

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
Source/modules/fetch/FetchDataLoader.cpp:281: m_outStream->flush();
I'm not sure if flushing is needed in this case.

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
File Source/modules/fetch/FetchDataLoader.h (right):

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
Source/modules/fetch/FetchDataLoader.h:60: static FetchDataLoader*
createLoaderAsStream(Stream* outStream);
Can you tell me why you like giving outStream in the constructor more than
creating it in the loader and passing it to the callback?

[hiroshige, 2015-06-25 11:12:26]

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
File Source/modules/fetch/FetchDataLoader.cpp (right):

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
Source/modules/fetch/FetchDataLoader.cpp:249: bool needToFlush = false;
On 2015/06/25 10:53:33, yhirano wrote:
> This variable should be defined out of the loop.

Done.

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
Source/modules/fetch/FetchDataLoader.cpp:254: m_reader->endRead(available);
On 2015/06/25 10:53:33, yhirano wrote:
> needToFlush = true

Done.

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
Source/modules/fetch/FetchDataLoader.cpp:281: m_outStream->flush();
On 2015/06/25 10:53:33, yhirano wrote:
> I'm not sure if flushing is needed in this case.

Done.

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
File Source/modules/fetch/FetchDataLoader.h (right):

https://codereview.chromium.org/1204263002/diff/20001/Source/modules/fetch/Fe...
Source/modules/fetch/FetchDataLoader.h:60: static FetchDataLoader*
createLoaderAsStream(Stream* outStream);
On 2015/06/25 10:53:33, yhirano wrote:
> Can you tell me why you like giving outStream in the constructor more than
> creating it in the loader and passing it to the callback?

Because I want to create a stream, set to WebServiceWorkerResponse, and then
start streaming by start().

[yhirano, 2015-06-25 11:28:38]

lgtm

[hiroshige, 2015-06-25 11:30:32]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2015-06-25 11:31:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1204263002/40001

[commit-bot: I haz the power, 2015-06-25 12:39:35]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197818