Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: tests/compiler/dart2js/warnings_checker.dart

Issue 120423006: Compute correct constructor type for synthesized mixin constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use Platform.packageRoot. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/mixin_language_test.dart ('k') | tests/language/checked_mode_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/warnings_checker.dart
diff --git a/tests/compiler/dart2js/warnings_checker.dart b/tests/compiler/dart2js/warnings_checker.dart
index 1105b38f521d77281a2ba269005696fe085d7668..aa84570fd2e687c845e3c570d6afcf0bdfdc99d1 100644
--- a/tests/compiler/dart2js/warnings_checker.dart
+++ b/tests/compiler/dart2js/warnings_checker.dart
@@ -16,10 +16,11 @@ import '../../../sdk/lib/_internal/compiler/implementation/source_file_provider.
import '../../../sdk/lib/_internal/compiler/implementation/util/uri_extras.dart';
import 'dart:convert';
-void checkWarnings(Map<String, dynamic> tests) {
+void checkWarnings(Map<String, dynamic> tests, [List<String> arguments]) {
bool isWindows = Platform.isWindows;
Uri script = currentDirectory.resolveUri(Platform.script);
bool warningsMismatch = false;
+ bool verbose = arguments != null && arguments.contains('-v');
asyncTest(() => Future.forEach(tests.keys, (String test) {
Uri uri = script.resolve('../../$test');
String source = UTF8.decode(readAll(uriPathToNative(uri.path)));
@@ -38,7 +39,7 @@ void checkWarnings(Map<String, dynamic> tests) {
var compiler = compilerFor(const {},
diagnosticHandler: collector,
options: ['--analyze-only'],
- showDiagnostics: false);
+ showDiagnostics: verbose);
return compiler.run(uri).then((_) {
Map<String, List<int>> statusMap = tests[test];
// Line numbers with known unexpected warnings.
« no previous file with comments | « tests/compiler/dart2js/mixin_language_test.dart ('k') | tests/language/checked_mode_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698