LayoutTests/fast/dom/shadow/focus-controller-recursion-crash.html - Issue 1204213002: Avoid tail recursion to mitigate stack exhaustion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/shadow/focus-controller-recursion-crash.html

Issue 1204213002: Avoid tail recursion to mitigate stack exhaustion (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix for comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/js-test.js"></script>

	3 <div>This test passes if it does not crash.</div>

	4 <input id="first">

	5 <select></select>

	6 <input>

	7 <script>

	8 var sel = document.querySelector('select');

	9 for (var i = 0; i < 100000; ++i) {
	kochi 2015/06/25 08:44:05 I'm concerned that this is too much for layout tes I'm concerned that this is too much for layout test bots. On my 64bit linux box it started to crash over ~90000, but could be lower on other platforms. I'll lower the value and see if other bots fail till I can find a good threshold.
	10 var o = document.createElement('option');

	11 sel.appendChild(o);

	12 }

	13

	14 document.getElementById('first').focus();

	15

	16 eventSender.keyDown('\t');

	17 eventSender.keyDown('\t');

	18 eventSender.keyDown('\t', ['shiftKey']);

	19 eventSender.keyDown('\t', ['shiftKey']);

	20

	21 shouldBeEqualToString('document.activeElement.id', 'first');

	22 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/shadow/focus-controller-recursion-crash-expected.txt » ('j') | no next file with comments »