Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4572)

Unified Diff: chrome/common/extensions/extension_file_util.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_file_util.cc
diff --git a/chrome/common/extensions/extension_file_util.cc b/chrome/common/extensions/extension_file_util.cc
index 59f8b35f4face2ae784f4b8a30459b2c7154cb76..aa14e17290cb22d6b26a2b1a98772c433a479a31 100644
--- a/chrome/common/extensions/extension_file_util.cc
+++ b/chrome/common/extensions/extension_file_util.cc
@@ -329,7 +329,8 @@ bool ValidateExtension(const Extension* extension,
}
}
- const extensions::ActionInfo* action = extension->page_action_info();
+ const extensions::ActionInfo* action =
+ extensions::ActionInfo::GetPageActionInfo(extension);
if (action && !action->default_icon.empty() &&
!ValidateExtensionIconSet(action->default_icon, extension,
IDS_EXTENSION_LOAD_ICON_FOR_PAGE_ACTION_FAILED, error)) {

Powered by Google App Engine
This is Rietveld 408576698