Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2258)

Unified Diff: chrome/common/extensions/api/extension_action/action_info.h

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_action/action_info.h
diff --git a/chrome/common/extensions/api/extension_action/action_info.h b/chrome/common/extensions/api/extension_action/action_info.h
index 09e7eccf78176cd60113e2ce9ec1dfc9e0c541ff..f95fb4063761dc611cd47b15d1b3309e6a4e83ca 100644
--- a/chrome/common/extensions/api/extension_action/action_info.h
+++ b/chrome/common/extensions/api/extension_action/action_info.h
@@ -26,13 +26,22 @@ struct ActionInfo {
TYPE_SYSTEM_INDICATOR,
};
- // Returns the appropriate ActionInfo for the given |extension|.
+ // Returns the extension's page action, if any.
+ static const ActionInfo* GetPageActionInfo(const Extension* extension);
+
+ // Returns the extension's script badge.
static const ActionInfo* GetScriptBadgeInfo(const Extension* extension);
- // Sets the appropriate ActionInfo as ManifestData for the given |extension|.
- // This is static since |extension| takes ownership of |info|.
+ // Sets the extension's page action. |extension| takes ownership of |info|.
+ static void SetPageActionInfo(Extension* extension, ActionInfo* info);
+
+ // Sets the extension's script badge. |extension| takes ownership of |info|.
static void SetScriptBadgeInfo(Extension* extension, ActionInfo* info);
+ // Returns true if the extension needs a verbose install message because
+ // of its page action.
+ static bool IsVerboseInstallMessage(const Extension* extension);
+
// Empty implies the key wasn't present.
ExtensionIconSet default_icon;
std::string default_title;

Powered by Google App Engine
This is Rietveld 408576698