chrome/browser/ui/views/extensions/extension_installed_bubble.cc - Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc ('k') | chrome/chrome_common.gypi » ('j') | chrome/common/extensions/api/extension_action/page_action_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_installed_bubble.cc

diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc

index e76468cac20dfe324e97d1effe281bc7bc8aa004..98d5adaddd39fecc0c81bbe1335a66ab21261459 100644

--- a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc

+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc

@@ -28,6 +28,7 @@

#include "chrome/browser/ui/webui/ntp/new_tab_ui.h"

#include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"

#include "chrome/common/chrome_notification_types.h"

+#include "chrome/common/extensions/api/extension_action/action_info.h"

#include "chrome/common/extensions/api/omnibox/omnibox_handler.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/url_constants.h"

@@ -551,7 +552,7 @@ ExtensionInstalledBubble::ExtensionInstalledBubble(const Extension* extension,

else if (extension_action_manager->GetBrowserAction(*extension_))

type_ = BROWSER_ACTION;

else if (extension_action_manager->GetPageAction(*extension) &&

- extensions::OmniboxInfo::IsVerboseInstallMessage(extension))

+ extensions::ActionInfo::IsVerboseInstallMessage(extension))

type_ = PAGE_ACTION;

else

type_ = GENERIC;