Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc
deleted file mode 100644
index b77092b3a03e108420e70c46b8155c0fbe2a7dbd..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc
+++ /dev/null
@@ -1,25 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-
-#include "chrome/common/extensions/extension_manifest_constants.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace errors = extension_manifest_errors;
-
-TEST_F(ExtensionManifestTest, PageActionManifestVersion2) {
- scoped_refptr<extensions::Extension> extension(
- LoadAndExpectSuccess("page_action_manifest_version_2.json"));
- ASSERT_TRUE(extension.get());
- ASSERT_TRUE(extension->page_action_info());
-
- EXPECT_EQ("", extension->page_action_info()->id);
- EXPECT_TRUE(extension->page_action_info()->default_icon.empty());
- EXPECT_EQ("", extension->page_action_info()->default_title);
- EXPECT_TRUE(extension->page_action_info()->default_popup_url.is_empty());
-
- LoadAndExpectError("page_action_manifest_version_2b.json",
- errors::kInvalidPageActionPopup);
-}

Powered by Google App Engine
This is Rietveld 408576698