Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: chrome/renderer/extensions/page_actions_custom_bindings.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/page_actions_custom_bindings.h" 5 #include "chrome/renderer/extensions/page_actions_custom_bindings.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "chrome/common/extensions/api/extension_action/action_info.h"
9 #include "chrome/renderer/extensions/dispatcher.h" 10 #include "chrome/renderer/extensions/dispatcher.h"
10 #include "grit/renderer_resources.h" 11 #include "grit/renderer_resources.h"
11 #include "v8/include/v8.h" 12 #include "v8/include/v8.h"
12 13
13 namespace extensions { 14 namespace extensions {
14 15
15 PageActionsCustomBindings::PageActionsCustomBindings( 16 PageActionsCustomBindings::PageActionsCustomBindings(
16 Dispatcher* dispatcher) 17 Dispatcher* dispatcher)
17 : ChromeV8Extension(dispatcher) { 18 : ChromeV8Extension(dispatcher) {
18 RouteStaticFunction("GetCurrentPageActions", &GetCurrentPageActions); 19 RouteStaticFunction("GetCurrentPageActions", &GetCurrentPageActions);
19 } 20 }
20 21
21 // static 22 // static
22 v8::Handle<v8::Value> PageActionsCustomBindings::GetCurrentPageActions( 23 v8::Handle<v8::Value> PageActionsCustomBindings::GetCurrentPageActions(
23 const v8::Arguments& args) { 24 const v8::Arguments& args) {
24 PageActionsCustomBindings* self = 25 PageActionsCustomBindings* self =
25 GetFromArguments<PageActionsCustomBindings>(args); 26 GetFromArguments<PageActionsCustomBindings>(args);
26 std::string extension_id = *v8::String::Utf8Value(args[0]->ToString()); 27 std::string extension_id = *v8::String::Utf8Value(args[0]->ToString());
27 CHECK(!extension_id.empty()); 28 CHECK(!extension_id.empty());
28 const Extension* extension = 29 const Extension* extension =
29 self->dispatcher_->extensions()->GetByID(extension_id); 30 self->dispatcher_->extensions()->GetByID(extension_id);
30 CHECK(extension); 31 CHECK(extension);
31 32
32 v8::Local<v8::Array> page_action_vector = v8::Array::New(); 33 v8::Local<v8::Array> page_action_vector = v8::Array::New();
33 if (extension->page_action_info()) { 34 if (ActionInfo::GetPageActionInfo(extension)) {
34 std::string id = extension->page_action_info()->id; 35 std::string id = ActionInfo::GetPageActionInfo(extension)->id;
35 page_action_vector->Set(v8::Integer::New(0), 36 page_action_vector->Set(v8::Integer::New(0),
36 v8::String::New(id.c_str(), id.size())); 37 v8::String::New(id.c_str(), id.size()));
37 } 38 }
38 39
39 return page_action_vector; 40 return page_action_vector;
40 } 41 }
41 42
42 } // extensions 43 } // extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698