Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/api/extension_action/page_action_handler.h"
6 #include "chrome/common/extensions/extension_manifest_constants.h"
7 #include "chrome/common/extensions/manifest_handler.h"
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 8 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6
7 #include "chrome/common/extensions/extension_manifest_constants.h"
8 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
9 10
10 namespace errors = extension_manifest_errors; 11 namespace extensions {
11 12
12 TEST_F(ExtensionManifestTest, DisallowMultipleUISurfaces) { 13 class UIManifestTest : public ExtensionManifestTest {
13 LoadAndExpectError("multiple_ui_surfaces.json", errors::kOneUISurfaceOnly); 14 protected:
15 virtual void SetUp() OVERRIDE {
16 ExtensionManifestTest::SetUp();
17 ManifestMultiKeyHandler::Register(new PageActionHandler);
18 }
19 };
20
21 TEST_F(UIManifestTest, DisallowMultipleUISurfaces) {
22 LoadAndExpectError("multiple_ui_surfaces.json",
23 extension_manifest_errors::kOneUISurfaceOnly);
14 } 24 }
25
26 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698