Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 12042058: Re-enable some network tests disabled for Chrome Frame. (Closed)

Created:
7 years, 11 months ago by mmenke
Modified:
7 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Re-enable some network tests that have been disabled for over a year due to failures with Chrome Frame. Keep them disabled for Chrome Frame tests. Also disable two of them on Android. BUG=102991 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183367

Patch Set 1 #

Patch Set 2 : Disable one of the tests on android, too #

Patch Set 3 : Disable another on android #

Patch Set 4 : Sync #

Patch Set 5 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M build/android/pylib/gtest/filter/net_unittests_disabled View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
mmenke
Tests still seem to be passing.
7 years, 11 months ago (2013-01-23 20:52:13 UTC) #1
erikwright (departed)
LGTM.
7 years, 11 months ago (2013-01-23 20:53:12 UTC) #2
mmenke
On 2013/01/23 20:53:12, erikwright wrote: > LGTM. Thanks!
7 years, 11 months ago (2013-01-23 20:54:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/12042058/1
7 years, 11 months ago (2013-01-23 20:57:51 UTC) #4
mmenke
[+pliard]: Please take a look at the Android change.
7 years, 11 months ago (2013-01-23 23:22:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/12042058/11003
7 years, 11 months ago (2013-01-25 15:17:01 UTC) #6
commit-bot: I haz the power
Failed to apply patch for build/android/pylib/gtest/filter/net_unittests_disabled: While running patch -p0 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 11 months ago (2013-01-25 15:17:03 UTC) #7
Philippe
lgtm, Thanks Matt and sorry for the delay.
7 years, 11 months ago (2013-01-25 15:22:14 UTC) #8
mmenke
On 2013/01/25 15:22:14, Philippe wrote: > lgtm, Thanks Matt and sorry for the delay. Not ...
7 years, 11 months ago (2013-01-25 15:29:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/12042058/2006
7 years, 11 months ago (2013-01-25 15:34:07 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=92985
7 years, 11 months ago (2013-01-25 18:00:11 UTC) #11
mmenke
On 2013/01/25 18:00:11, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 11 months ago (2013-01-25 18:10:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/12042058/17001
7 years, 10 months ago (2013-02-19 20:34:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/12042058/17001
7 years, 10 months ago (2013-02-20 00:13:52 UTC) #14
mmenke
7 years, 10 months ago (2013-02-20 02:01:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 manually as r183367.

Powered by Google App Engine
This is Rietveld 408576698