Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 12042048: Use -fPIC instead of -fPIE for ThreadSanitizer v2 (Closed)

Created:
7 years, 11 months ago by Alexander Potapenko
Modified:
7 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Use -fPIC instead of -fPIE for ThreadSanitizer v2 BUG=171402, 128314 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
TBR
7 years, 11 months ago (2013-01-23 10:39:18 UTC) #1
Nico
Every CL description should describe why a change is done (effects, things that are currently ...
7 years, 11 months ago (2013-01-23 20:39:37 UTC) #2
Alexander Potapenko
7 years, 11 months ago (2013-01-24 08:57:30 UTC) #3
Message was sent while issue was closed.
Sorry about that. I used to think that a link to crbug is more important, since
it has all the relevant information. I'll be more accurate in my future commits.

For the record (if anyone is going to read this issue trying to understand why
the change has been made), the problem here is that every file in Chrome has
been compiled with -fPIE, including those ending up linked into a .so. Because
-fPIE is only applicable to executable binaries, and the targets are built only
once (i.e. there're no versions of modules for executables and shared objects),
we had to replace -fPIE with -fPIC.

Powered by Google App Engine
This is Rietveld 408576698